Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VO-1167] feat: Remove some development flags #3238

Merged
merged 5 commits into from
Oct 25, 2024
Merged

[VO-1167] feat: Remove some development flags #3238

merged 5 commits into from
Oct 25, 2024

Conversation

cballevre
Copy link
Contributor 

### ✨ Features

* Revert `drive.show-nextcloud-dev` to `drive.hide-nextcloud-dev` so the feature is activated by default
* Remove `drive.show-favorites-dev`

@cballevre cballevre requested review from zatteo and Merkur39 October 25, 2024 08:44
@cballevre cballevre requested a review from acezard as a code owner October 25, 2024 08:44
@cballevre cballevre force-pushed the feat/clean-dev-flags branch from 892d685 to 0996b05 Compare October 25, 2024 08:50
@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 25, 2024

BundleMon

Files updated (2)
Status Path Size Limits
✅ public/drive.(hash).js
 1.56MB (-103B -0.01%) 1.7MB
✅ app/drive.(hash).js
 160.99KB (-130B -0.08%) 300KB
Unchanged files (16)
Status Path Size Limits
✅ vendors/drive.(hash).js
 1.79MB 2MB
✅ public/pdf.worker.entry.(hash).worker.js
 345.35KB 350KB
✅ services/qualificationMigration/drive.js
 282.15KB 500KB
✅ services/dacc/drive.js
 263.08KB 500KB
✅ public/cozy-client-js.js
 159.28KB 160KB
✅ intents/drive.(hash).js
 87.66KB 190KB
✅ public/drive.(hash).min.css
 39.94KB 100KB
✅ onlyOffice/slide.pptx
 24.83KB 25KB
✅ app-drive.(hash).min.css
 10.73KB 56KB
✅ intents-drive.(hash).min.css
 7.89KB 40KB
✅ onlyOffice/text.docx
 5.85KB 6KB
✅ onlyOffice/spreadsheet.xlsx
 5.02KB 6KB
✅ manifest.webapp
 1.87KB 2KB
✅ index.html
 596B 1KB
✅ intents/index.html
 507B 1KB
✅ manifest.json
 185B 1KB

Total files change -234B 0%

Groups updated (2)
Status Path Size Limits
✅ public/**
 2.11MB (-104B 0%) -
✅ app/**
 160.99KB (-130B -0.08%) -
Unchanged groups (5)
Status Path Size Limits
✅ vendors/**
 1.79MB -
✅ services/**
 545.23KB -
✅ intents/**
 88.15KB -
✅ onlyOffice/**
 35.7KB -
✅ img/**
 5.85KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@cballevre cballevre merged commit c7ae333 into master Oct 25, 2024
4 checks passed
@cballevre cballevre deleted the feat/clean-dev-flags branch October 25, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zatteo zatteo zatteo approved these changes

@Merkur39 Merkur39 Awaiting requested review from Merkur39 Merkur39 is a code owner

@acezard acezard Awaiting requested review from acezard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cballevre @zatteo